Mahmoud Alkhraishi: Probably. we're passing fail tests but not passing pass tests. I believe I did something on our end to fix, so that's probably what's going on. ✪
Orie Steele: Quick comment - lot of work done to maintain optional param noones using, remove? ✪
Chris Abernethy: Have to, otherwise ppl can't participate at all ✪
Orie Steele: Make supporting themd efault case remove optional details. Other way of saying, anyone getting value out of tests only excluding id? ✪
Chris Abernethy: Already removed them. that's why this client var exists, now justa ssume we're passing tests and if you need wonky names then specify. ✪
Mahmoud Alkhraishi: Awesome. going to add comment please address pr, merge offline. chris ask orie to review again after made changes ✪
Orie Steele: Just removes deprecated suites not using, pretty straightfwd, refers to media type, could change but better to rfer to that than suite no one's using ✪
Mahmoud Alkhraishi: Do we expect to continue jsonwebkey2020, or just jsonwebkey? ✪
Orie Steele: I'd suggest just jsonwebkey. all applies to did doc not context credential ✪
Benjamin Collins: Basic schema issue of type str and add format of datetime to make sure it's specific form of datetime for format. using it more consistently across schemas, tho I don't it should be scaled across all issues ✪
Mahmoud Alkhraishi: Writing that in as additional action item. ✪
Benjamin Collins: Assigned myself. I can do a pass. ✪
Mahmoud Alkhraishi: Added ready for pr label. anything else on this? great ✪
Nis Jespersen : We can be more precise than a string, standard being applied. I think this'd be the right way to express the content that is the mill test. ✪
Mahmoud Alkhraishi: Thank you, next up, max size limit for json-ld vc's ✪
Ted Thibodeau: Just followed link to presented elongation, wrong link. ✪
Mahmoud Alkhraishi: Fair. but going to need to go through all of them anyway. will note that. ✪
Ted Thibodeau: Really problematic. taking one product's arbitrary limitation, smaller than file size limits on any os, saying "this tiny thing is how big any" ✪
Benjamin Collins: More around time it takes to sign. could even time out on i7 with 32gigs mem. Jsonld the canonical op before signing, there's a practical term ✪
Ted Thibodeau: Diff argument than "mongo has this limit" ✪
Mahmoud Alkhraishi: Look at last two links in orie's comment. ✪
Ted Thibodeau: Ok, so, this should be doc'd, "there's a practical limit here and this is why" ✪
Mahmoud Alkhraishi: Underlying thing, chris, we are moving away from canonicalization anyway ✪
Benjamin Collins: Practical limit on what can be computed. If quantumn computing let's you do it in half a sec, that's a technical dependency. ANd then chri's point if we move away from canonicalization, it's just hashing the bytes. ✪
Ted Thibodeau: Also noting, this is a deployment tradeoff. may be that x hours is worthwhile ✪
Mahmoud Alkhraishi: Not hard no, "this is guidance plz follow guidance". Someone can still do it ✪
Benjamin Collins: Part of use case is transactions, if need 100's of transactions/min. if have datacenter, 300cpus, 3 terabytes mem and you want to spend all day signing something, go ahead ✪